Page MenuHomePhabricator
Differential D16054

Lift ticks declaration to top level in Phabricator daemons
ClosedPublic
Actions

Authored by epriestley on Jun 6 2016, 1:35 PM.
Tags
None
Referenced Files
F15448328: D16054.id38629.diff
Fri, Mar 28, 4:13 AM
F15441293: D16054.id.diff
Wed, Mar 26, 5:22 PM
F15440222: D16054.id38629.diff
Wed, Mar 26, 11:23 AM
F15434841: D16054.diff
Tue, Mar 25, 5:41 AM
F15387709: D16054.diff
Sat, Mar 15, 2:48 AM
F15387456: D16054.id38627.diff
Sat, Mar 15, 2:25 AM
F15367155: D16054.id38627.diff
Tue, Mar 11, 4:22 PM
F15282503: D16054.diff
Mar 4 2025, 12:17 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10811: `phd-daemon` crash after automatic restart following config change
Commits
rP0bf337b06c1f: Lift ticks declaration to top level in Phabricator daemons
Summary

Ref T10811. This is a companion change for D16053, but affects the Phabricator version of this script.

Test Plan

Started daemons, ^C'd them, saw them handle the signal.

Diff Detail

Repository
rP Phabricator
Branch
daemon2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12498
Build 15843: Run Core Tests
Build 15842: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38627.Jun 6 2016, 1:35 PM
epriestley retitled this revision from to Lift ticks declaration to top level in Phabricator daemons.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10811: `phd-daemon` crash after automatic restart following config change.
chad accepted this revision.Jun 6 2016, 1:37 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2016, 1:37 PM
Closed by commit rP0bf337b06c1f: Lift ticks declaration to top level in Phabricator daemons (authored by epriestley, committed by epriestley). · Explain WhyJun 6 2016, 1:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
scripts/
daemon/
2 lines

Diff 38627

View Options

scripts/daemon/launch_daemon.php

Loading...
Phabricator · Built by Phacility