Page MenuHomePhabricator
Differential D16027

Modernize "favorite project policies" setting
ClosedPublic
Actions

Authored by epriestley on Jun 3 2016, 4:23 PM.
Tags
None
Referenced Files
F14015500: D16027.diff
Sun, Nov 3, 7:50 PM
F14013839: D16027.id38558.diff
Sat, Nov 2, 5:09 PM
F14012136: D16027.id38579.diff
Fri, Nov 1, 7:23 AM
F13999314: D16027.id38579.diff
Thu, Oct 24, 2:08 PM
F13990268: D16027.diff
Tue, Oct 22, 2:19 AM
F13979718: D16027.diff
Oct 19 2024, 6:03 AM
Unknown Object (File)
Sep 9 2024, 5:05 PM
Unknown Object (File)
Sep 4 2024, 2:45 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4103: Implement "Role Profiles" to provide search, homepage and application defaults
Commits
rP44e88f186c86: Modernize "favorite project policies" setting
Summary

Ref T4103. Convert this into a proper internal setting and use transactions to mutate it.

Also remove some no-longer-used old non-modular settings constants.

Test Plan
  • Used policy dropdown, saw recently-used projects.
  • Selected some new projects, saw them appear.
  • Grepped for all removed constants.

Diff Detail

Repository
rP Phabricator
Branch
setting17
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12427
Build 15741: Run Core Tests
Build 15740: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38558.Jun 3 2016, 4:23 PM
epriestley retitled this revision from to Modernize "favorite project policies" setting.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
chad accepted this revision.Jun 3 2016, 5:55 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 5:55 PM
Closed by commit rP44e88f186c86: Modernize "favorite project policies" setting (authored by epriestley, committed by epriestley). · Explain WhyJun 4 2016, 9:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
people/
storage/
9 lines
policy/
controller/
19 lines
query/
2 lines
settings/
setting/
16 lines
storage/
20 lines
view/
phui/
calendar/
2 lines

Diff 38558

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/applications/policy/controller/PhabricatorPolicyEditController.php

Loading...
View Options

src/applications/policy/query/PhabricatorPolicyQuery.php

Loading...
View Options

src/applications/settings/setting/PhabricatorPolicyFavoritesSetting.php

Loading...
View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
Phabricator · Built by Phacility