Page MenuHomePhabricator
Differential D16026

Convert Diffusion blame and color into standard internal settings
ClosedPublic
Actions

Authored by epriestley on Jun 3 2016, 2:49 PM.
Tags
None
Referenced Files
F15478775: D16026.diff
Tue, Apr 8, 2:43 AM
F15446549: D16026.id.diff
Thu, Mar 27, 7:33 PM
F15441944: D16026.diff
Wed, Mar 26, 8:42 PM
F15427333: D16026.id38557.diff
Sun, Mar 23, 1:50 PM
F15385944: D16026.id38557.diff
Fri, Mar 14, 11:43 PM
F15282482: D16026.id.diff
Mar 4 2025, 12:15 AM
Unknown Object (File)
Feb 18 2025, 1:09 AM
Unknown Object (File)
Feb 12 2025, 3:17 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4103: Implement "Role Profiles" to provide search, homepage and application defaults
Commits
rP5c8ff3d37c2a: Convert Diffusion blame and color into standard internal settings
Summary

Ref T4103. Modernize the blame/color toggles in Diffusion. These have no separate settings UI.

Test Plan

Toggled blame and colors, reloaded pages, settings stuck.

Diff Detail

Repository
rP Phabricator
Branch
setting16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12426
Build 15739: Run Core Tests
Build 15738: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38557.Jun 3 2016, 2:49 PM
epriestley retitled this revision from to Convert Diffusion blame and color into standard internal settings.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
chad accepted this revision.Jun 3 2016, 2:50 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 2:50 PM
Closed by commit rP5c8ff3d37c2a: Convert Diffusion blame and color into standard internal settings (authored by epriestley, committed by epriestley). · Explain WhyJun 4 2016, 9:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
diffusion/
controller/
31 lines
settings/
setting/
16 lines
16 lines
storage/
31 lines

Diff 38557

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

src/applications/settings/setting/PhabricatorDiffusionBlameSetting.php

Loading...
View Options

src/applications/settings/setting/PhabricatorDiffusionColorSetting.php

Loading...
View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...
Phabricator · Built by Phacility