Differential D16021

Fix reading ad-hoc settings with no formal Settings object
ClosedPublic
Actions

Authored by epriestley on Jun 3 2016, 1:05 PM.

Details

Reviewers

chad

Maniphest Tasks

T4103: Implement "Role Profiles" to provide search, homepage and application defaults

Commits

rPd5f924b3fabb: Fix reading ad-hoc settings with no formal Settings object

Summary

Ref T4103. Some settings (like the collapsed/expanded state of the diff filetree) are currently ad-hoc. They weren't being read correctly.

Also, simplify the caching code a little bit.

Test Plan

Toggled filetree, reloaded page, got sticky behavior.

Diff Detail

Repository

rP Phabricator

Branch

setting11

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12421
Build 15729: Run Core Tests
Build 15728: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38552.Jun 3 2016, 1:05 PM

epriestley retitled this revision from to Fix reading ad-hoc settings with no formal Settings object.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

chad accepted this revision.Jun 3 2016, 5:52 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 3 2016, 5:52 PM

Closed by commit rPd5f924b3fabb: Fix reading ad-hoc settings with no formal Settings object (authored by epriestley, committed by epriestley). · Explain WhyJun 4 2016, 9:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

storage/

PhabricatorUser.php

19 lines

Diff 38552

View Options

src/applications/people/storage/PhabricatorUser.php

Fix reading ad-hoc settings with no formal Settings objectClosedPublicActions