Page MenuHomePhabricator
Differential D16010

Give Phame blogs an explicit 404 controller
ClosedPublic
Actions

Authored by epriestley on Jun 2 2016, 2:39 PM.
Tags
None
Referenced Files
F18776496: D16010.id38533.diff
Fri, Oct 10, 10:12 PM
F18768766: D16010.diff
Wed, Oct 8, 5:16 AM
F18733360: D16010.id.diff
Tue, Sep 30, 10:33 PM
F18732390: D16010.id.diff
Tue, Sep 30, 5:55 PM
F18720591: D16010.diff
Mon, Sep 29, 7:27 PM
F18619295: D16010.diff
Sep 15 2025, 2:11 AM
F18581260: D16010.id38533.diff
Sep 11 2025, 5:28 AM
F18581229: D16010.id38533.diff
Sep 11 2025, 5:20 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9897: Unbeta Feedback on Phame
T11076: Ship CORGI
Commits
rP03e54afc146c: Give Phame blogs an explicit 404 controller
Summary

Ref T11076. Ref T9897. Bad links on Phame blogs are currently made worse because we try to prompt you to login on a non-cookie domain.

Instead, just 404 in a vanilla way. Do so cleanly on external domains.

Test Plan

Screen Shot 2016-06-02 at 7.37.58 AM.png (1×1 px, 120 KB)

Diff Detail

Repository
rP Phabricator
Branch
blog1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12408
Build 15710: Run Core Tests
Build 15709: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38532.Jun 2 2016, 2:39 PM
epriestley retitled this revision from to Give Phame blogs an explicit 404 controller.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T11076: Ship CORGI, T9897: Unbeta Feedback on Phame.
Herald edited edge metadata. · View Herald TranscriptJun 2 2016, 2:39 PM
chad accepted this revision.Jun 2 2016, 3:13 PM
chad edited edge metadata.
chad added inline comments.
src/applications/phame/site/Phame404Response.php
33

Hehe

This revision is now accepted and ready to land.Jun 2 2016, 3:13 PM
Closed by commit rP03e54afc146c: Give Phame blogs an explicit 404 controller (authored by epriestley, committed by epriestley). · Explain WhyJun 2 2016, 4:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
4 lines
applications/
phame/
application/
2 lines
controller/
33 lines
blog/
14 lines
6 lines
site/
43 lines
webroot/
rsrc/
css/
application/
phame/
10 lines

Diff 38532

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/application/PhabricatorPhameApplication.php

Loading...
View Options

src/applications/phame/controller/PhameLiveController.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlog404Controller.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogViewController.php

Loading...
View Options

src/applications/phame/site/Phame404Response.php

Loading...
View Options

webroot/rsrc/css/application/phame/phame.css

Loading...
Phabricator · Built by Phacility