Page MenuHomePhabricator

Make Settings modular and allow them to be EditEngine'd
ClosedPublic

Authored by epriestley on May 31 2016, 8:59 PM.
Tags
None
Referenced Files
F14045254: D15995.id.diff
Wed, Nov 13, 2:28 AM
F14044972: D15995.diff
Tue, Nov 12, 11:37 PM
F14039838: D15995.id.diff
Mon, Nov 11, 6:27 AM
F14015844: D15995.diff
Mon, Nov 4, 1:30 AM
F14010288: D15995.id.diff
Thu, Oct 31, 6:53 AM
F14005713: D15995.id.diff
Sun, Oct 27, 6:08 PM
F13987769: D15995.id38501.diff
Mon, Oct 21, 11:12 AM
Unknown Object (File)
Sep 21 2024, 8:04 AM
Subscribers
None

Details

Summary

Ref T4103. This starts breaking out settings in a modern way to prepare for global defaults.

Test Plan
  • Edited diff settings.
  • Saw them take effect in primary settings pane.
  • Set stuff to new automatic defaults.
  • Tried to edit another user's settings.
  • Edited a bot's settings as an administrator.

Screen Shot 2016-05-31 at 1.54.04 PM.png (973×1 px, 159 KB)

Diff Detail

Repository
rP Phabricator
Branch
settings3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/settings/editor/PhabricatorSettingsEditEngine.php:69XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 12377
Build 15663: Run Core Tests
Build 15662: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make Settings modular and allow them to be EditEngine'd.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 31 2016, 9:11 PM
This revision was automatically updated to reflect the committed changes.