Add role=dialog to all dialogs
ClosedPublic
Actions

Authored by chad on May 31 2016, 7:20 PM.

Tags

None

Referenced Files

	F15423018: D15993.id38496.diff
	Sat, Mar 22, 12:09 PM

	F15403098: D15993.diff
	Mar 18 2025, 1:54 AM

	F15284800: D15993.diff
	Mar 4 2025, 10:33 AM

	F15282462: D15993.diff
	Mar 4 2025, 12:14 AM

	Unknown Object (File)
	Mar 3 2025, 11:37 PM

	Unknown Object (File)
	Mar 3 2025, 11:37 PM

	Unknown Object (File)
	Feb 25 2025, 1:10 AM

	Unknown Object (File)
	Feb 16 2025, 6:53 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPb23c85b16915: Add role=dialog to all dialogs

Summary

Seen some complaints about usability here, adding role=dialog to improve when these trigger.

Test Plan

Turn on Voiceover, tab over to log out link, here proper dialog title and text before highlighted submit button.

Diff Detail

Repository

rP Phabricator

Branch

role-dialog (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12372
Build 15656: Run Core Tests
Build 15655: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38495.May 31 2016, 7:20 PM

chad retitled this revision from to Add role=dialog to all dialogs.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMay 31 2016, 7:20 PM

epriestley accepted this revision.May 31 2016, 7:20 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 31 2016, 7:20 PM

Closed by commit rPb23c85b16915: Add role=dialog to all dialogs (authored by chad, committed by chad). · Explain WhyMay 31 2016, 7:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

AphrontDialogView.php

1 line

Diff 38495

View Options

src/view/AphrontDialogView.php

Add role=dialog to all dialogsClosedPublicActions