Page MenuHomePhabricator

Prepare UserPreferences for transactions
ClosedPublic

Authored by epriestley on May 31 2016, 3:35 PM.
Tags
None
Referenced Files
F18230364: D15991.diff
Wed, Aug 20, 12:24 PM
F18196806: D15991.id38497.diff
Sun, Aug 17, 7:31 PM
F18142561: D15991.id.diff
Thu, Aug 14, 1:03 PM
F18127014: D15991.diff
Wed, Aug 13, 3:10 PM
F17949515: D15991.id38492.diff
Thu, Jul 31, 11:38 PM
F17947346: D15991.id38497.diff
Thu, Jul 31, 4:17 PM
F17829747: D15991.id38492.diff
Sat, Jul 26, 10:19 AM
Unknown Object (File)
Jul 3 2025, 2:06 PM
Subscribers
None

Details

Summary

Ref T4103. This give preferences a PHID, policy/transaction interfaces, a transaction table, and a Query class.

This doesn't actually change how they're edited, yet.

Test Plan
  • Ran migrations.
  • Inspected database for date created, date modified, PHIDs.
  • Changed some of my preferences.
  • Deleted a user's preferences, verified they reset properly.
  • Set some preferences as a new user, got a new row.
  • Destroyed a user, verified their preferences were destroyed.
  • Sent Conpherence messages.
  • Send mail.
  • Tried to edit another user's settings.
  • Tried to edit a bot's settings as a non-admin.
  • Edited a bot's settings as an admin (technically, none of the editable settings are actually stored in the settings table, currently).

Diff Detail

Repository
rP Phabricator
Branch
settings2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/settings/storage/PhabricatorUserPreferences.php:215XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 12369
Build 15651: Run Core Tests
Build 15650: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Prepare UserPreferences for transactions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 31 2016, 3:51 PM
This revision was automatically updated to reflect the committed changes.