Details
Details
- Reviewers
chad - Maniphest Tasks
- T11051: "Explain Why" isn't properly explaining why revisions were closed
- Commits
- rPe81637a6c686: Fix some issues with the "Explain Why" dialog
Did this sort of thing in a repository:
$ git checkout -b featurex $ echo x >> y $ git commit -am wip $ arc diff
Then I simulated just pushing it (this flow is a little more involved than necessary):
$ arc land --hold $ git commit --amend $ # remove all metadata -- particularly, "Differential Revision"! $ git push HEAD:master
I got a not-great but more-useful dialog:
Prior to this change, the hash match was incorrectly not reported at all.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- xplain2
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 12362 Build 15642: Run Core Tests Build 15641: arc lint + arc unit