Page MenuHomePhabricator
Differential D15982

Read "Database Status" page connection information from cluster config if present
ClosedPublic
Actions

Authored by epriestley on May 26 2016, 7:13 PM.
Tags
None
Referenced Files
F13243035: D15982.diff
Thu, May 23, 3:17 AM
F13221436: D15982.diff
Sun, May 19, 2:46 AM
F13209531: D15982.id38475.diff
Fri, May 17, 12:47 AM
F13208829: D15982.id38476.diff
Thu, May 16, 7:53 PM
F13203826: D15982.diff
Wed, May 15, 12:08 AM
F13186407: D15982.diff
Sat, May 11, 3:36 AM
Unknown Object (File)
Tue, May 7, 6:40 AM
Unknown Object (File)
Mon, May 6, 1:30 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11043: Database status page throws an exception if `mysql.host` not explicitly set in a clustered environment
Commits
rP74a36f9d7bf0: Read "Database Status" page connection information from cluster config if…
Summary

Fixes T11043. This page was still reading the old information directly instead of going through the cluster-aware stuff.

Have it ask the cluster-aware stuff for information instead.

Test Plan
  • Nuked MySQL on localhost.
  • Configured cluster hosts.
  • Loaded "Database Status" page -- worked after patch.
  • Grepped for any remaining mysql.configuration-provider stragglers, came up empty.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38475.May 26 2016, 7:13 PM
epriestley retitled this revision from to Read "Database Status" page connection information from cluster config if present.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11043: Database status page throws an exception if `mysql.host` not explicitly set in a clustered environment.
chad accepted this revision.May 26 2016, 7:14 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 26 2016, 7:14 PM
Closed by commit rP74a36f9d7bf0: Read "Database Status" page connection information from cluster config if… (authored by epriestley, committed by epriestley). · Explain WhyMay 26 2016, 7:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
controller/
12 lines

Diff 38476

View Options

src/applications/config/controller/PhabricatorConfigDatabaseController.php

Loading...
Phabricator · Built by Phacility