Differential D15978

Separate locales into more usable groups in the translation menu
ClosedPublic
Actions

Authored by epriestley on May 26 2016, 1:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 5:24 PM

	Unknown Object (File)
	Thu, Dec 19, 12:28 PM

	Unknown Object (File)
	Tue, Dec 10, 8:35 PM

	Unknown Object (File)
	Mon, Dec 9, 11:19 AM

	Unknown Object (File)
	Sun, Dec 8, 8:15 PM

	Unknown Object (File)
	Sun, Dec 8, 7:54 AM

	Unknown Object (File)
	Sun, Dec 8, 7:54 AM

	Unknown Object (File)
	Sun, Dec 8, 7:50 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T4103: Implement "Role Profiles" to provide search, homepage and application defaults
T5267: Localize Phabricator

Commits

rP10ffa42504db: Separate locales into more usable groups in the translation menu

Summary

Ref T5267. Ref T4103. Currently, adding new locale support to the upstream fills this menu with confusing options which don't do anything. Separate it into four groups:

Translations: these have a "reasonable number" of strings and you'll probably see some obvious effect if you switch to the translation.
Limited Translations: these have very few or no strings, and include locales which we've added but don't ship translations for.
Silly Translations: Pirate english, etc.
Test Translations: ALLCAPS, raw strings, etc.

Czech is currently in "test" instead of "limited" for historical reasons; I'll remedy this in the next change.

Test Plan

Screen Shot 2016-05-26 at 6.48.30 AM.png (333×576 px, 53 KB)

Diff Detail

Repository

Branch

pref2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/settings/panel/PhabricatorAccountSettingsPanel.php:141	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 12340
Build 15609: Run Core Tests
Build 15608: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38465.May 26 2016, 1:54 PM

epriestley retitled this revision from to Separate locales into more usable groups in the translation menu.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T5267: Localize Phabricator, T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

chad accepted this revision.May 26 2016, 2:43 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 26 2016, 2:43 PM

Closed by commit rP10ffa42504db: Separate locales into more usable groups in the translation menu (authored by epriestley, committed by epriestley). · Explain WhyMay 26 2016, 3:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

panel/

PhabricatorAccountSettingsPanel.php

101 lines

Diff 38465

src/applications/settings/panel/PhabricatorAccountSettingsPanel.php

Loading...