Page MenuHomePhabricator
Differential D15969

Fix a possible fatal on the first push to a cluster repository
ClosedPublic
Actions

Authored by epriestley on May 24 2016, 12:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 9, 1:18 PM
Unknown Object (File)
Mon, Sep 2, 1:49 AM
Unknown Object (File)
Wed, Aug 28, 11:26 PM
Unknown Object (File)
Wed, Aug 28, 3:33 PM
Unknown Object (File)
Sat, Aug 24, 8:01 PM
Unknown Object (File)
Wed, Aug 21, 3:20 PM
Unknown Object (File)
Sat, Aug 17, 10:16 PM
Unknown Object (File)
Aug 10 2024, 8:40 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11020: Pushing to an unactivated cluster repository can freeze the repository in a locked state?
Commits
rP9f399247b1b1: (stable) Fix a possible fatal on the first push to a cluster repository
rPbb16a1b0e2a8: Fix a possible fatal on the first push to a cluster repository
Summary

Fixes T11020. I think this resolves things -- $new_version (set above) should be used, not $new_log directly.

Specifically, we would get into trouble if the initial push failed for some reason (working copy not initialized yet, commit hook rejected, etc).

Test Plan

Made a bad push to a new repository. Saw it freeze before the patch and succeed afterwards.

Diff Detail

Repository
rP Phabricator
Branch
freeze1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12321
Build 15582: Run Core Tests
Build 15581: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38446.May 24 2016, 12:15 AM
epriestley retitled this revision from to Fix a possible fatal on the first push to a cluster repository.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11020: Pushing to an unactivated cluster repository can freeze the repository in a locked state?.
chad accepted this revision.May 24 2016, 12:53 AM
chad edited edge metadata.
This revision is now accepted and ready to land.May 24 2016, 12:53 AM
Closed by commit rPbb16a1b0e2a8: Fix a possible fatal on the first push to a cluster repository (authored by epriestley, committed by epriestley). · Explain WhyMay 24 2016, 12:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
protocol/
2 lines

Diff 38446

View Options

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

Loading...
Phabricator · Built by Phacility