Make View Revision in Mail a little more resilient
ClosedPublic
Actions

Authored by chad on May 20 2016, 6:57 PM.

Tags

None

Referenced Files

	F15335996: D15955.id38416.diff
	Sat, Mar 8, 6:03 PM

	F15334352: D15955.id38415.diff
	Sat, Mar 8, 8:28 AM

	F15331392: D15955.diff
	Fri, Mar 7, 9:59 AM

	F15286069: D15955.id38416.diff
	Tue, Mar 4, 5:59 PM

	Unknown Object (File)
	Sun, Mar 2, 10:19 AM

	Unknown Object (File)
	Sun, Mar 2, 10:19 AM

	Unknown Object (File)
	Thu, Feb 27, 9:16 PM

	Unknown Object (File)
	Wed, Feb 12, 4:11 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP58aa3fdc9d44: Make View Revision in Mail a little more resilient

Summary

Converts to table so text wraps on long strings well, button always stays top right, better spacing underneath.

Test Plan

Mail, Gmail, mobile

Diff Detail

Repository

rP Phabricator

Branch

mail-2 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12285
Build 15529: Run Core Tests
Build 15528: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38415.May 20 2016, 6:57 PM

chad retitled this revision from to Make View Revision in Mail a little more resilient.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMay 20 2016, 6:57 PM

epriestley accepted this revision.May 20 2016, 7:02 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 20 2016, 7:02 PM

Closed by commit rP58aa3fdc9d44: Make View Revision in Mail a little more resilient (authored by chad, committed by chad). · Explain WhyMay 20 2016, 7:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

28 lines

Diff 38415

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Make View Revision in Mail a little more resilientClosedPublicActions