Page MenuHomePhabricator
Differential D15951

Restore viewer() function to "Responsible Users" tokenizer in Differential
ClosedPublic
Actions

Authored by epriestley on May 19 2016, 8:46 PM.
Tags
None
Referenced Files
F14832185: D15951.diff
Thu, Jan 30, 4:20 AM
Unknown Object (File)
Wed, Jan 29, 4:52 PM
Unknown Object (File)
Fri, Jan 24, 3:54 AM
Unknown Object (File)
Thu, Jan 23, 3:21 PM
Unknown Object (File)
Thu, Jan 23, 1:59 PM
Unknown Object (File)
Thu, Jan 23, 12:20 PM
Unknown Object (File)
Tue, Jan 21, 7:59 PM
Unknown Object (File)
Dec 31 2024, 7:07 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10939: Support for OWNERS files
Commits
rP45718268a96e: Restore viewer() function to "Responsible Users" tokenizer in Differential
Summary

Ref T10939. This makes the viewer() function work again. It retains its own meaning (viewer, plus all their projects and packages).

There's no exact-viewer() function; we could conceivably add one eventually if we need it.

Test Plan
  • Queried for viewer(), got the same results as querying by my own username.
  • Browsed function in token browser.
  • Reviewed autogenerated documentation.

Diff Detail

Repository
rP Phabricator
Branch
diff2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12275
Build 15515: Run Core Tests
Build 15514: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38405.May 19 2016, 8:46 PM
epriestley retitled this revision from to Restore viewer() function to "Responsible Users" tokenizer in Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10939: Support for OWNERS files.
chad accepted this revision.May 19 2016, 10:10 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 19 2016, 10:10 PM
Closed by commit rP45718268a96e: Restore viewer() function to "Responsible Users" tokenizer in Differential (authored by epriestley, committed by epriestley). · Explain WhyMay 19 2016, 10:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38405

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/typeahead/DifferentialResponsibleDatasource.php

Loading...
View Options

src/applications/differential/typeahead/DifferentialResponsibleUserDatasource.php

Loading...
View Options

src/applications/differential/typeahead/DifferentialResponsibleViewerFunctionDatasource.php

Loading...
Phabricator · Built by Phacility