Paths

Table of Contentst

Differential D15936

Allow users to manage package dominion rules
ClosedPublic
Actions

Authored by epriestley on May 17 2016, 3:04 AM.

Tags

None

Referenced Files

	F14849333: D15936.diff
	Tue, Feb 4, 1:47 AM

	Unknown Object (File)
	Thu, Jan 30, 10:51 AM

	Unknown Object (File)
	Sat, Jan 25, 10:01 PM

	Unknown Object (File)
	Fri, Jan 24, 7:44 AM

	Unknown Object (File)
	Thu, Jan 23, 8:24 PM

	Unknown Object (File)
	Thu, Jan 23, 3:10 PM

	Unknown Object (File)
	Thu, Jan 23, 6:10 AM

	Unknown Object (File)
	Fri, Jan 17, 10:50 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10939: Support for OWNERS files

Commits

rP809c7bf996af: Allow users to manage package dominion rules

Summary

Ref T10939. This adds UI, transactions, etc, to adjust dominion rules.

Test Plan

Read documentation.
Changed dominion rules.
Created packages on / ("A") and /x ("B") with "Auto Review: Review".
Touched /x.
Verified that A and B were added with strong dominion.
Verified that only B was added when A was set to weak dominion.
Viewed file in Diffusion, saw correct ownership with strong/weak dominion rules.

Diff Detail

Repository

Branch

dash13

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12240
Build 15463: Run Core Tests
Build 15462: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38367.May 17 2016, 3:04 AM

epriestley retitled this revision from to Allow users to manage package dominion rules.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10939: Support for OWNERS files.

epriestley mentioned this in T10939: Support for OWNERS files.May 17 2016, 12:36 PM

chad accepted this revision.May 17 2016, 3:32 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 17 2016, 3:32 PM

Closed by commit rP809c7bf996af: Allow users to manage package dominion rules (authored by epriestley, committed by epriestley). · Explain WhyMay 17 2016, 5:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20160516.owners.01.dominion.sql

2 lines

20160516.owners.02.dominionstrong.sql

2 lines

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

7 lines

owners/

controller/

PhabricatorOwnersDetailController.php

7 lines

editor/

PhabricatorOwnersPackageEditEngine.php

13 lines

PhabricatorOwnersPackageTransactionEditor.php

28 lines

query/

PhabricatorOwnersPackageQuery.php

14 lines

storage/

PhabricatorOwnersPackage.php

18 lines

PhabricatorOwnersPackageTransaction.php

13 lines

docs/

user/

userguide/

36 lines

Diff 38367

resources/sql/autopatches/20160516.owners.01.dominion.sql

Loading...

resources/sql/autopatches/20160516.owners.02.dominionstrong.sql

Loading...

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...

src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php

Loading...

src/applications/owners/editor/PhabricatorOwnersPackageTransactionEditor.php

Loading...

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

Loading...

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...

src/applications/owners/storage/PhabricatorOwnersPackageTransaction.php

Loading...

src/docs/user/userguide/owners.diviner

Loading...