Page MenuHomePhabricator
Differential D15878

Improve behavior for not-yet-created non-cluster repositories
ClosedPublic
Actions

Authored by epriestley on May 10 2016, 2:15 PM.
Tags
None
Referenced Files
F14068090: D15878.diff
Tue, Nov 19, 7:25 PM
F14059183: D15878.diff
Sun, Nov 17, 6:01 PM
F14050810: D15878.diff
Thu, Nov 14, 8:49 PM
F14050590: D15878.id38261.diff
Thu, Nov 14, 7:36 PM
F14046537: D15878.id38244.diff
Wed, Nov 13, 9:45 PM
F14034173: D15878.diff
Sat, Nov 9, 10:34 PM
F14029012: D15878.id38261.diff
Fri, Nov 8, 6:44 PM
F14019315: D15878.diff
Tue, Nov 5, 9:54 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10815: Confusing diffusion error with empty, non-activated hosted repository
Commits
rP3fdb1a2bc437: Improve behavior for not-yet-created non-cluster repositories
Summary

Fixes T10815. We already recovered reasonably from this for cluster repositories, but not for non-cluster repositories.

Test Plan
  • Viewed cluster and non-cluster empty Git repository.
  • Viewed cluster and non-cluster empty Mercurial repository.
  • Viewed cluster and non-clsuter empty hosted SVN repository.
  • Viewed cluster and non-cluster empty observed SVN repository.

Diff Detail

Repository
rP Phabricator
Branch
dxdoc12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12130
Build 15300: Run Core Tests
Build 15299: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38244.May 10 2016, 2:15 PM
epriestley retitled this revision from to Improve behavior for not-yet-created non-cluster repositories.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10815: Confusing diffusion error with empty, non-activated hosted repository.
chad edited edge metadata.May 11 2016, 3:05 AM

Unit tests?

chad accepted this revision.May 11 2016, 3:09 AM
chad edited edge metadata.
This revision is now accepted and ready to land.May 11 2016, 3:09 AM
epriestley updated this revision to Diff 38255.May 11 2016, 3:30 AM
epriestley edited edge metadata.
  • Likely fix for tests.
chad added a comment.May 11 2016, 3:45 AM

Macro ninjacat:

epriestley updated this revision to Diff 38260.May 11 2016, 1:37 PM
  • Rebase to pick up unit test fix.
Closed by commit rP3fdb1a2bc437: Improve behavior for not-yet-created non-cluster repositories (authored by epriestley, committed by epriestley). · Explain WhyMay 11 2016, 1:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
query/
lowlevel/
5 lines
repository/
engine/
__tests__/
1 line
storage/
9 lines

Diff 38255

View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php

Loading...
View Options

src/applications/repository/engine/__tests__/PhabricatorWorkingCopyTestCase.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility