Page MenuHomePhabricator

Improve behavior for not-yet-created non-cluster repositories
ClosedPublic

Authored by epriestley on May 10 2016, 2:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 7 2025, 4:57 PM
Unknown Object (File)
May 4 2025, 4:01 AM
Unknown Object (File)
May 2 2025, 4:23 AM
Unknown Object (File)
Apr 14 2025, 11:51 PM
Unknown Object (File)
Apr 5 2025, 10:08 PM
Unknown Object (File)
Apr 5 2025, 12:35 PM
Unknown Object (File)
Apr 1 2025, 9:04 AM
Unknown Object (File)
Mar 28 2025, 6:55 PM
Subscribers
None

Details

Summary

Fixes T10815. We already recovered reasonably from this for cluster repositories, but not for non-cluster repositories.

Test Plan
  • Viewed cluster and non-cluster empty Git repository.
  • Viewed cluster and non-cluster empty Mercurial repository.
  • Viewed cluster and non-clsuter empty hosted SVN repository.
  • Viewed cluster and non-cluster empty observed SVN repository.

Diff Detail

Repository
rP Phabricator
Branch
dxdoc13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12119
Build 15280: Run Core Tests
Build 15279: arc lint + arc unit

Unit TestsFailed

TimeTest
87 msPhabricatorChangeParserTestCase::Unknown Unit Message ("")
EXCEPTION (PhutilAggregateException): Multiple exceptions were raised during test execution. - Execution: LiskEphemeralObjectException: - Shutdown: Exception: Process exited with an open transaction! The transaction will be implicitly rolled back. Calls to openTransaction() must always be paired with a call to saveTransaction() or killTransaction().
0 msAlmanacNamesTestCase::Unknown Unit Message ("")
30 assertions passed.
0 msAlmanacServiceTypeTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
2 assertions passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
3 assertions passed.
View Full Test Results (1 Failed · 330 Passed)

Event Timeline

epriestley retitled this revision from to Improve behavior for not-yet-created non-cluster repositories.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 11 2016, 3:09 AM
epriestley edited edge metadata.
  • Likely fix for tests.
  • Rebase to pick up unit test fix.
This revision was automatically updated to reflect the committed changes.