Page MenuHomePhabricator
Differential D15855

Produce a more defensible HTML mail rendering of Remarkup blockquotes
ClosedPublic
Actions

Authored by epriestley on May 5 2016, 7:28 PM.
Tags
None
Referenced Files
F15383824: D15855.id38195.diff
Fri, Mar 14, 6:04 PM
F15381575: D15855.id.diff
Fri, Mar 14, 8:27 AM
F15331913: D15855.id38196.diff
Fri, Mar 7, 3:14 PM
Unknown Object (File)
Wed, Feb 26, 10:44 AM
Unknown Object (File)
Tue, Feb 25, 12:01 AM
Unknown Object (File)
Feb 16 2025, 5:26 PM
Unknown Object (File)
Feb 16 2025, 6:47 AM
Unknown Object (File)
Feb 9 2025, 1:31 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7031: Blockquote formatting in HTML mail could be improved
T10694: Improve behavior of context for inline comments in mail
Commits
rPHUd4e36c61b1ac: Produce a more defensible HTML mail rendering of Remarkup blockquotes
Summary

Ref T10694. Fixes T7031. We don't currently put any inline styles on <blockquote> tags produced by prefixing blocks with > in Remarkup.

Add some styles.

Test Plan

Generated some reasonable mail with complex blockquote elements:

Screen Shot 2016-05-05 at 12.26.34 PM.png (1×1 px, 249 KB)

Diff Detail

Repository
rPHU libphutil
Branch
blockquote1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12070
Build 15206: Run Core Tests
Build 15205: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38195.May 5 2016, 7:28 PM
epriestley retitled this revision from to Produce a more defensible HTML mail rendering of Remarkup blockquotes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10694: Improve behavior of context for inline comments in mail, T7031: Blockquote formatting in HTML mail could be improved.
chad accepted this revision.May 5 2016, 7:29 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 5 2016, 7:29 PM
Closed by commit rPHUd4e36c61b1ac: Produce a more defensible HTML mail rendering of Remarkup blockquotes (authored by epriestley, committed by epriestley). · Explain WhyMay 5 2016, 7:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
remarkup/
blockrule/
16 lines

Diff 38195

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupQuotesBlockRule.php

Loading...
Phabricator · Built by Phacility