Page MenuHomePhabricator
Differential D15841

Cut mirroring over to new URIs
ClosedPublic
Actions

Authored by epriestley on May 3 2016, 9:04 PM.
Tags
None
Referenced Files
F15483288: D15841.id38154.diff
Wed, Apr 9, 11:27 AM
F15477312: D15841.diff
Mon, Apr 7, 1:25 PM
F15464990: D15841.id.diff
Wed, Apr 2, 1:28 PM
F15443684: D15841.id38168.diff
Thu, Mar 27, 5:40 AM
F15436996: D15841.id38154.diff
Tue, Mar 25, 4:57 PM
F15435906: D15841.id.diff
Tue, Mar 25, 10:50 AM
F15432305: D15841.diff
Mon, Mar 24, 5:25 PM
F15415410: D15841.diff
Thu, Mar 20, 5:49 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API
Commits
rP42eaa88f8031: Cut mirroring over to new URIs
Summary

Ref T10748. This migrates and swaps mirroring to PhabricatorRepositoryURI, obsoleting PhabricatorRepositoryMirror.

This prevents you from editing, adding or disabling mirrors unless you know a secret URI (until the UI cuts over fully), but existing mirroring is not affected.

Test Plan

Diff Detail

Repository
rP Phabricator
Branch
repo27
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/repository/storage/PhabricatorRepositoryMirror.php:4XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 12030
Build 15143: Run Core Tests
Build 15142: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38154.May 3 2016, 9:04 PM
epriestley retitled this revision from to Cut mirroring over to new URIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
epriestley added inline comments.May 3 2016, 9:07 PM
src/applications/repository/engine/PhabricatorRepositoryMirrorEngine.php
49–53

As a bonus, this is no longer garbage.

chad accepted this revision.May 3 2016, 9:13 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 3 2016, 9:13 PM
Closed by commit rP42eaa88f8031: Cut mirroring over to new URIs (authored by epriestley, committed by epriestley). · Explain WhyMay 4 2016, 11:16 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.May 5 2016, 12:15 AM

Revision Contents
Changeset List

Diff 38154

View Options

resources/sql/autopatches/20160503.repo.04.mirrormigrate.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionMirrorDeleteController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionMirrorEditController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryMirrorEngine.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementMirrorWorkflow.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryMirrorPHIDType.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryMirrorQuery.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryMirror.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryURI.php

Loading...
Phabricator · Built by Phacility