Page MenuHomePhabricator
Differential D15840

Add "wide" remarkup image support for Documents
ClosedPublic
Actions

Authored by chad on May 3 2016, 8:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 8:49 PM
Unknown Object (File)
Thu, Feb 27, 7:16 PM
Unknown Object (File)
Sun, Feb 16, 6:46 AM
Unknown Object (File)
Feb 4 2025, 8:03 AM
Unknown Object (File)
Jan 25 2025, 2:06 PM
Unknown Object (File)
Jan 17 2025, 9:06 PM
Unknown Object (File)
Jan 4 2025, 5:53 PM
Unknown Object (File)
Dec 30 2024, 3:24 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPd85386488bf5: Add "wide" remarkup image support for Documents
Summary

Seems to work ok, if you give size=wide to an image file, we blow it out a bit in DocumentPro mode.

Test Plan

Test in Phame and Maniphest.

Screen Shot 2016-05-03 at 1.54.17 PM.png (2×2 px, 1 MB)

Screen Shot 2016-05-03 at 1.54.27 PM.png (2×2 px, 1 MB)

Diff Detail

Repository
rP Phabricator
Branch
wide-remarkup-embed (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12029
Build 15141: Run Core Tests
Build 15140: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38153.May 3 2016, 8:56 PM
chad retitled this revision from to Add "wide" remarkup image support for Documents.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMay 3 2016, 8:56 PM
epriestley accepted this revision.May 3 2016, 8:56 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 3 2016, 8:56 PM
chad edited the test plan for this revision. (Show Details)May 3 2016, 8:56 PM
chad edited edge metadata.
chad added inline comments.
webroot/rsrc/css/phui/phui-document.css
106

just... be on the lookout?

epriestley added inline comments.May 3 2016, 8:57 PM
webroot/rsrc/css/phui/phui-document.css
106

haha yeah this might get suspicious

epriestley added a comment.May 3 2016, 8:57 PM

Only thing I can really think of offhand is huge tables.

chad added a comment.May 3 2016, 8:58 PM

lemme do more testing then. I think tables overflow scroll though

epriestley added a comment.May 3 2016, 8:59 PM

Yeah, I'd expect them to be OK.

Maybe a table with a {wide} image inside it? Not sure what users would really expect that to do, though.

Closed by commit rPd85386488bf5: Add "wide" remarkup image support for Documents (authored by chad, committed by chad). · Explain WhyMay 4 2016, 12:27 AM
This revision was automatically updated to reflect the committed changes.
chad added a comment.May 4 2016, 12:29 AM

doitlive

chad added a comment.May 4 2016, 12:29 AM

pls roll secure

Revision Contents
Changeset List

PathSize
resources/
celerity/
14 lines
src/
applications/
files/
markup/
8 lines
webroot/
rsrc/
css/
core/
6 lines
phui/
19 lines
1 line

Diff 38153

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
View Options

webroot/rsrc/css/phui/phui-document-pro.css

Loading...
View Options

webroot/rsrc/css/phui/phui-document.css

Loading...
Phabricator · Built by Phacility