Page MenuHomePhabricator
Differential D15824

Alternate fix for Firefox triple click selection
ClosedPublic
Actions

Authored by epriestley on Apr 29 2016, 11:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 3, 7:42 PM
Unknown Object (File)
Mon, May 26, 12:32 AM
Unknown Object (File)
Tue, May 20, 9:20 AM
Unknown Object (File)
Apr 19 2025, 8:34 PM
Unknown Object (File)
Apr 18 2025, 5:03 AM
Unknown Object (File)
Apr 17 2025, 8:52 AM
Unknown Object (File)
Apr 17 2025, 7:29 AM
Unknown Object (File)
Apr 15 2025, 8:44 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10905: Cannot triple-click to select task title in phabricator (due to icon in the title)
Commits
rPe8dca5a4f9be: Alternate fix for Firefox triple click selection
Summary

Fixes T10905. This reverts D15823, which didn't work well for tasks with very long titles (the title would break as a block element).

This is slightly more magic but works with long titles.

Test Plan

Did everything from D15823, but also with long titles. Triple-click, wrapping, and mobile/device worked in Safari, Firefox and Chrome.

Diff Detail

Repository
rP Phabricator
Branch
3clickff2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11996
Build 15090: Run Core Tests
Build 15089: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38123.Apr 29 2016, 11:56 PM
epriestley retitled this revision from to Alternate fix for Firefox triple click selection.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10905: Cannot triple-click to select task title in phabricator (due to icon in the title).
Herald edited edge metadata. · View Herald TranscriptApr 29 2016, 11:56 PM
chad accepted this revision.Apr 29 2016, 11:58 PM
chad edited edge metadata.

shipitquick

This revision is now accepted and ready to land.Apr 29 2016, 11:58 PM
Closed by commit rPe8dca5a4f9be: Alternate fix for Firefox triple click selection (authored by epriestley, committed by epriestley). · Explain WhyApr 29 2016, 11:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
phui/
9 lines
webroot/
rsrc/
css/
phui/
6 lines

Diff 38123

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
Phabricator · Built by Phacility