Page MenuHomePhabricator
Differential D15821

Add `diffusion.uri.edit` for creating and editing repository URIs
ClosedPublic
Actions

Authored by epriestley on Apr 29 2016, 8:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 2:12 PM
Unknown Object (File)
Sat, Jan 25, 5:56 PM
Unknown Object (File)
Fri, Jan 24, 1:41 PM
Unknown Object (File)
Fri, Jan 24, 1:41 PM
Unknown Object (File)
Fri, Jan 24, 1:41 PM
Unknown Object (File)
Tue, Jan 21, 9:40 AM
Unknown Object (File)
Sun, Jan 19, 6:12 AM
Unknown Object (File)
Sat, Jan 18, 3:54 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API
Commits
rPda599386f645: Add `diffusion.uri.edit` for creating and editing repository URIs
Summary

Ref T10748. Brings the rest of the transactions to EditEngine, supports creating via API.

Test Plan
  • Created a URI via API.
  • Created a URI via web.
  • Tried to apply sneaky transactions, got rejected with good error messages. <_< >_>

Diff Detail

Repository
rP Phabricator
Branch
repo13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11990
Build 15081: Run Core Tests
Build 15080: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38117.Apr 29 2016, 8:37 PM
epriestley retitled this revision from to Add `diffusion.uri.edit` for creating and editing repository URIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
chad accepted this revision.Apr 29 2016, 8:44 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 29 2016, 8:44 PM
Closed by commit rPda599386f645: Add `diffusion.uri.edit` for creating and editing repository URIs (authored by epriestley, committed by epriestley). · Explain WhyApr 29 2016, 8:55 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.Apr 30 2016, 12:43 AM

Revision Contents
Changeset List

Diff 38117

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/conduit/DiffusionURIEditConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/editor/DiffusionURIEditEngine.php

Loading...
View Options

src/applications/diffusion/editor/DiffusionURIEditor.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryURI.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryURITransaction.php

Loading...
Phabricator · Built by Phacility