Page MenuHomePhabricator
Differential D15813

Give users a modal VCS choice when creating a new repository
ClosedPublic
Actions

Authored by epriestley on Apr 28 2016, 11:31 AM.
Tags
None
Referenced Files
F13982684: D15813.diff
Sun, Oct 20, 1:09 AM
F13980835: D15813.id38093.diff
Sat, Oct 19, 12:47 PM
F13963214: D15813.id38113.diff
Tue, Oct 15, 2:35 PM
Unknown Object (File)
Oct 11 2024, 7:49 PM
Unknown Object (File)
Oct 10 2024, 7:29 AM
Unknown Object (File)
Oct 9 2024, 11:05 AM
Unknown Object (File)
Sep 25 2024, 3:23 PM
Unknown Object (File)
Sep 25 2024, 1:08 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API
Commits
rP0459e9524257: Give users a modal VCS choice when creating a new repository
Summary

Ref T10748. Allow the new EditEngine workflow to create repositories by giving the user a modal repository type choice upfront.

(The rest of this flow is still confusing/weird, though.)

Test Plan
  • Created a new repository.

Screen Shot 2016-04-28 at 4.22.52 AM.png (1×1 px, 123 KB)

Diff Detail

Repository
rP Phabricator
Branch
repo9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11966
Build 15048: Run Core Tests
Build 15047: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38093.Apr 28 2016, 11:31 AM
epriestley retitled this revision from to Give users a modal VCS choice when creating a new repository.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
chad edited edge metadata.Apr 28 2016, 5:16 PM

imgres.jpg (225×225 px, 13 KB)

chad accepted this revision.Apr 28 2016, 5:18 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 28 2016, 5:18 PM
Closed by commit rP0459e9524257: Give users a modal VCS choice when creating a new repository (authored by epriestley, committed by epriestley). · Explain WhyApr 29 2016, 4:20 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.Apr 30 2016, 12:43 AM

Revision Contents
Changeset List

Diff 38093

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditproController.php

Loading...
View Options

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryStatusManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryURIsManagementPanel.php

Loading...
View Options

src/applications/repository/constants/PhabricatorRepositoryType.php

Loading...
Phabricator · Built by Phacility