Differential D15799

Prevent web queries from running for more than 30 seconds
ClosedPublic
Actions

Authored by epriestley on Apr 26 2016, 12:16 PM.

Details

Reviewers

chad

Maniphest Tasks

T10849: Support query timeouts via `max_statement_time` or MYSLQI_ASYNC

Commits

rP0630fef9fc36: Prevent web queries from running for more than 30 seconds

Summary

Ref T10849. This enforces a global 30-second per-query time limit for anything not coming from the CLI.

If we run into another issue with MySQL hanging in the future, this should prevent it from being nearly as bad as it was.

Test Plan

Set value to 0, verified the UI threw an exception immediately.
Set value back to 30, browsed around a bunch of pages.

Diff Detail

Repository

rP Phabricator

Branch

timeout1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11933
Build 14999: Run Core Tests
Build 14998: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38059.Apr 26 2016, 12:16 PM

epriestley retitled this revision from to Prevent web queries from running for more than 30 seconds.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10849: Support query timeouts via `max_statement_time` or MYSLQI_ASYNC.

chad accepted this revision.Apr 26 2016, 2:22 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 26 2016, 2:22 PM

Closed by commit rP0630fef9fc36: Prevent web queries from running for more than 30 seconds (authored by epriestley, committed by epriestley). · Explain WhyApr 26 2016, 2:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

storage/

lisk/

PhabricatorLiskDAO.php

6 lines

Diff 38059

View Options

src/infrastructure/storage/lisk/PhabricatorLiskDAO.php

Prevent web queries from running for more than 30 secondsClosedPublicActions