Send the `aphlict` process log to the `node` log
ClosedPublic
Actions

Authored by epriestley on Apr 22 2016, 12:01 AM.

Details

Reviewers

chad

Commits

rP0f0105e783ef: Send the `aphlict` process log to the `node` log

Summary

I've possibly seen a couple of aphlict processes exit under suspicious circumstances (maybe?). Make sure any PHP errors get captured into the log.

Test Plan

Added an exception after forking.
Before change: vanished into thin air.
After change: visible in the log.

Diff Detail

Repository

rP Phabricator

Branch

notify1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11893
Build 14939: Run Core Tests
Build 14938: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38021.Apr 22 2016, 12:01 AM

epriestley retitled this revision from to Send the `aphlict` process log to the `node` log.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Also print more diagnostic information about signals.

chad accepted this revision.Apr 22 2016, 12:43 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 22 2016, 12:43 AM

Closed by commit rP0f0105e783ef: Send the `aphlict` process log to the `node` log (authored by epriestley, committed by epriestley). · Explain WhyApr 22 2016, 12:55 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

aphlict/

management/

PhabricatorAphlictManagementWorkflow.php

33 lines

Diff 38022

View Options

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

Send the `aphlict` process log to the `node` logClosedPublicActions