Page MenuHomePhabricator
Differential D15780

Fix Phriction link syntax a little more
ClosedPublic
Actions

Authored by epriestley on Apr 21 2016, 5:28 PM.
Tags
None
Referenced Files
F14838380: D15780.diff
Fri, Jan 31, 3:19 PM
Unknown Object (File)
Tue, Jan 28, 9:01 AM
Unknown Object (File)
Thu, Jan 23, 9:26 AM
Unknown Object (File)
Tue, Jan 21, 9:59 AM
Unknown Object (File)
Dec 28 2024, 1:09 PM
Unknown Object (File)
Dec 26 2024, 4:45 PM
Unknown Object (File)
Dec 20 2024, 10:54 PM
Unknown Object (File)
Dec 20 2024, 10:52 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rPfb2b88a4a81f: Fix Phriction link syntax a little more
Summary

This still wasn't quite right -- a link like [[ Porcupine Facts ]] with a space would not lookup correctly, and would render as porcupine_facts.

Test Plan

Verified that [[ Porcupine Facts ]] now works correctly.

Diff Detail

Repository
rP Phabricator
Branch
wiki2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11886
Build 14929: Run Core Tests
Build 14928: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38015.Apr 21 2016, 5:28 PM
epriestley retitled this revision from to Fix Phriction link syntax a little more.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Apr 21 2016, 5:28 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2016, 5:28 PM
Closed by commit rPfb2b88a4a81f: Fix Phriction link syntax a little more (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2016, 5:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
markup/
7 lines

Diff 38015

View Options

src/applications/phriction/markup/PhrictionRemarkupRule.php

Loading...
Phabricator · Built by Phacility