Rough in the new custom URI panel
ClosedPublic
Actions

Authored by epriestley on Apr 17 2016, 3:39 PM.

Details

Reviewers

Maniphest Tasks

T10366: General support for multiple URIs for a repository
T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API

Commits

rP92c50de8aac5: Rough in the new custom URI panel

Summary

Ref T10748. Ref T10366. No support for editing and no impact on the UI, but get some of the basics in place.

Test Plan

Screen Shot 2016-04-17 at 8.17.39 AM.png (1×1 px, 161 KB)

Diff Detail

Repository

rP Phabricator

Branch

repo5

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/repository/storage/PhabricatorRepository.php:2386	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 11804
Build 14805: Run Core Tests
Build 14804: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37932.Apr 17 2016, 3:39 PM

epriestley retitled this revision from to Rough in the new custom URI panel.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API, T10366: General support for multiple URIs for a repository.

chad accepted this revision.Apr 17 2016, 4:50 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 17 2016, 4:50 PM

Closed by commit rP92c50de8aac5: Rough in the new custom URI panel (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2016, 11:03 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.Apr 19 2016, 9:06 PM

epriestley mentioned this in T10366: General support for multiple URIs for a repository.Apr 19 2016, 9:37 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

diffusion/

management/

DiffusionRepositoryURIsManagementPanel.php

126 lines

repository/

storage/

PhabricatorRepository.php

94 lines

PhabricatorRepositoryURI.php

300 lines

docs/

user/

userguide/

diffusion_uris.diviner

47 lines

Diff 37932

View Options

src/__phutil_library_map__.php

View Options

src/applications/diffusion/management/DiffusionRepositoryURIsManagementPanel.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/applications/repository/storage/PhabricatorRepositoryURI.php

View Options

src/docs/user/userguide/diffusion_uris.diviner

Rough in the new custom URI panelClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37932

src/__phutil_library_map__.php

src/applications/diffusion/management/DiffusionRepositoryURIsManagementPanel.php

src/applications/repository/storage/PhabricatorRepository.php

src/applications/repository/storage/PhabricatorRepositoryURI.php

src/docs/user/userguide/diffusion_uris.diviner

Rough in the new custom URI panel
ClosedPublic
Actions

Revision Contents
Changeset List