Paths

Table of Contentst

Trivially implement RepositoryEditEngine and API methods
ClosedPublic
Actions

Authored by epriestley on Apr 17 2016, 12:05 AM.

Details

Reviewers

Maniphest Tasks

T10337: Implement `diffusion.search` and think about `diffusion.edit`
T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API

Commits

rPadf42db5ea2d: Trivially implement RepositoryEditEngine and API methods

Summary

Ref T10748. Ref T10337. This technically implements this stuff, but it does not do anything useful yet. This skips all the hard stuff.

Test Plan

Technically used diffusion.repository.search to get repository information.
Technically used diffusion.repository.edit to change a repository name.
Used editpro/ to edit a repository name.

Diff Detail

Repository

rP Phabricator

Branch

repo1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11791
Build 14785: Run Core Tests
Build 14784: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37919.Apr 17 2016, 12:05 AM

epriestley retitled this revision from to Trivially implement RepositoryEditEngine and API methods.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API, T10337: Implement `diffusion.search` and think about `diffusion.edit`.

epriestley added a child revision: D15737: Rough in basics + policies + history repository management panels.Apr 17 2016, 1:08 AM

chad accepted this revision.Apr 17 2016, 2:16 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 17 2016, 2:16 AM

Closed by commit rPadf42db5ea2d: Trivially implement RepositoryEditEngine and API methods (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2016, 11:02 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.Apr 19 2016, 9:06 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

9 lines

applications/

diffusion/

application/

PhabricatorDiffusionApplication.php

4 lines

conduit/

DiffusionRepositoryEditConduitAPIMethod.php

20 lines

DiffusionRepositorySearchConduitAPIMethod.php

18 lines

controller/

DiffusionRepositoryEditproController.php

12 lines

editor/

DiffusionRepositoryEditEngine.php

84 lines

repository/

storage/

PhabricatorRepository.php

41 lines

Diff 37919

View Options

src/__phutil_library_map__.php

View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

View Options

src/applications/diffusion/conduit/DiffusionRepositoryEditConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionRepositorySearchConduitAPIMethod.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditproController.php

View Options

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

Trivially implement RepositoryEditEngine and API methodsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37919

src/__phutil_library_map__.php

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

src/applications/diffusion/conduit/DiffusionRepositoryEditConduitAPIMethod.php

src/applications/diffusion/conduit/DiffusionRepositorySearchConduitAPIMethod.php

src/applications/diffusion/controller/DiffusionRepositoryEditproController.php

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

src/applications/repository/storage/PhabricatorRepository.php

Trivially implement RepositoryEditEngine and API methods
ClosedPublic
Actions

Revision Contents
Changeset List