Differential D15728

Allow users to be banished from Conpherence rooms
ClosedPublic
Actions

Authored by epriestley on Apr 15 2016, 9:51 PM.

Details

Reviewers

chad

Maniphest Tasks

T9348: No way to kick users out of a Conpherence

Commits

rPfe40be7fc92b: Allow users to be banished from Conpherence rooms

Summary

Fixes T9348. If you have edit permission, you can kick people out of a room.

Test Plan

Kicked people out of a room.
As an unprivileged user, wasn't able to kick people out of a room.
Hit most (all?) of the various weird dialog sub-cases.

Diff Detail

Repository

rP Phabricator

Branch

conp1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11771
Build 14754: Run Core Tests
Build 14753: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37902.Apr 15 2016, 9:51 PM

epriestley retitled this revision from to Allow users to be banished from Conpherence rooms.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9348: No way to kick users out of a Conpherence.

chad accepted this revision.Apr 15 2016, 9:56 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 15 2016, 9:56 PM

Closed by commit rPfe40be7fc92b: Allow users to be banished from Conpherence rooms (authored by epriestley, committed by epriestley). · Explain WhyApr 15 2016, 9:57 PM

This revision was automatically updated to reflect the committed changes.

exp10r3r mentioned this in D15168: Enable removal of users from chat rooms in Conpherence.Apr 16 2016, 4:12 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceUpdateController.php

79 lines

view/

ConpherencePeopleWidgetView.php

18 lines

Diff 37902

View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php