Page MenuHomePhabricator
Differential D15723

Fixing UI Example that use badge qualities
ClosedPublic
Actions

Authored by lpriestley on Apr 15 2016, 5:52 PM.
Tags
None
Referenced Files
F15587175: D15723.diff
Thu, May 8, 9:55 PM
F15581984: D15723.id37889.diff
Wed, May 7, 2:20 PM
F15580552: D15723.diff
Wed, May 7, 6:22 AM
F15569270: D15723.id37888.diff
Sat, May 3, 7:16 PM
F15547092: D15723.id.diff
Sat, Apr 26, 6:12 PM
F15540114: D15723.diff
Fri, Apr 25, 6:35 AM
F15531460: D15723.id37888.diff
Wed, Apr 23, 11:19 AM
F15490643: D15723.id.diff
Fri, Apr 11, 7:18 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T10706: Update old badge quality constants in PHUIBadgeExample
Commits
rP7b27653f5714: Fixing UI Example that use badge qualities
Summary

Fixes T10706

Test Plan

Open UI Example of badges. Shouldn't be broken

Diff Detail

Repository
rP Phabricator
Branch
badgesqualityconstants
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11757
Build 14731: Run Core Tests
Build 14730: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 37888.Apr 15 2016, 5:52 PM
lpriestley retitled this revision from to Fixing UI Example that use badge qualities.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T10706: Update old badge quality constants in PHUIBadgeExample.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 15 2016, 5:52 PM
Herald added a subscriber: Korvin. · View Herald Transcript
chad accepted this revision.Apr 15 2016, 6:05 PM
chad added a reviewer: chad.
This revision is now accepted and ready to land.Apr 15 2016, 6:05 PM
Closed by commit rP7b27653f5714: Fixing UI Example that use badge qualities (authored by lpriestley, committed by lpriestley). · Explain WhyApr 15 2016, 6:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
uiexample/
examples/
20 lines
2 lines
5 lines

Diff 37888

View Options

src/applications/uiexample/examples/PHUIBadgeExample.php

Loading...
View Options

src/applications/uiexample/examples/PHUIBoxExample.php

Loading...
View Options

src/applications/uiexample/examples/PHUITimelineExample.php

Loading...
Phabricator · Built by Phacility