Page MenuHomePhabricator
Differential D15683

Rough cut at new "pro" Diffusion edit UI skeleton
ClosedPublic
Actions

Authored by epriestley on Apr 11 2016, 5:35 PM.
Tags
None
Referenced Files
F17713435: D15683.id37801.diff
Thu, Jul 17, 1:48 PM
F17689819: D15683.id.diff
Mon, Jul 14, 2:04 PM
F17689400: D15683.id37791.diff
Mon, Jul 14, 12:24 PM
F17679675: D15683.diff
Sun, Jul 13, 2:42 PM
F17625421: D15683.diff
Thu, Jul 10, 3:15 AM
Unknown Object (File)
Jul 2 2025, 5:03 AM
Unknown Object (File)
May 27 2025, 11:01 AM
Unknown Object (File)
May 18 2025, 7:57 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4292: Implement repository replication
Commits
rP8a153c1fe96f: Rough cut at new "pro" Diffusion edit UI skeleton
Summary

Ref T4292. This puts a very rough skeleton in place for the new "Manage Repository" UI, somewhat similar to the "Settings" UI.

Right now, it has one panel with no content, and is not reachable from the UI.

Test Plan

Screen Shot 2016-04-11 at 10.31.59 AM.png (1×1 px, 107 KB)

Diff Detail

Repository
rP Phabricator
Branch
crepo2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/controller/DiffusionRepositoryManageController.php:9XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 11660
Build 14590: Run Core Tests
Build 14589: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37791.Apr 11 2016, 5:35 PM
epriestley retitled this revision from to Rough cut at new "pro" Diffusion edit UI skeleton.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4292: Implement repository replication.
epriestley updated this object.Apr 11 2016, 5:36 PM
chad accepted this revision.Apr 11 2016, 5:39 PM
chad edited edge metadata.

fyi, I do have a better design/layout for this in mind, should be easy to implement/retrofit.

src/applications/diffusion/management/DiffusionRepositoryClusterManagementPanel.php
13

seems like a magic number

This revision is now accepted and ready to land.Apr 11 2016, 5:39 PM
epriestley added inline comments.Apr 11 2016, 5:41 PM
src/applications/diffusion/management/DiffusionRepositoryClusterManagementPanel.php
13

don't worry I double-checked it

it's definitely magic

Closed by commit rP8a153c1fe96f: Rough cut at new "pro" Diffusion edit UI skeleton (authored by epriestley, committed by epriestley). · Explain WhyApr 12 2016, 12:37 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 13 2016, 3:33 AM

Revision Contents
Changeset List

Diff 37791

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryManageController.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryClusterManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryManagementPanel.php

Loading...
Phabricator · Built by Phacility