Fix an issue with passing HTTP headers through in proxied cluster requests
ClosedPublic
Actions

Authored by epriestley on Apr 8 2016, 5:55 PM.

Details

Reviewers

chad

Commits

rP60e91d393421: Fix an issue with passing HTTP headers through in proxied cluster requests

Summary

I think this fixes the Mercurial + HTTP cluster issue. PHP adds HTTP_ but we were not stripping it, so we would convert an X-Whatever-Zebra header into an Http-X-Whatever-Zebra header.

I don't think this behavior has changed? So maybe it just never worked? Git is more popular than Mercurial and SSH is easier to configure than HTTP, so it's plausible. I'll keep a careful eye on this when it deploys.

Test Plan

Set up local service-based Mercurial repository.
Tried to clone, got similar error to cluster.
Applied patch, clean clone.

Diff Detail

Repository

rP Phabricator

Branch

fheader

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11602
Build 14504: Run Core Tests
Build 14503: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37740.Apr 8 2016, 5:55 PM

epriestley retitled this revision from to Fix an issue with passing HTTP headers through in proxied cluster requests.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Apr 8 2016, 6:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 8 2016, 6:03 PM

Closed by commit rP60e91d393421: Fix an issue with passing HTTP headers through in proxied cluster requests (authored by epriestley, committed by epriestley). · Explain WhyApr 8 2016, 6:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

AphrontRequest.php

1 line

Diff 37740

View Options

src/aphront/AphrontRequest.php

Fix an issue with passing HTTP headers through in proxied cluster requestsClosedPublicActions