Fixes T8613. This was pretty straightforward, I just never dug into it originally.
rawResultLimit = 0 just means "no limit", so the fix is to only apply a limit if it is set to some nonzero value.
Also modernize a few pieces of code.
Details
Details
I'm actually not sure this can actually be hit normally? I faked setGenerateGhosts(true) into an unrelated query, hit the fatal, then fixed it.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- calendar1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 11584 Build 14476: Run Core Tests Build 14475: arc lint + arc unit
Event Timeline
Comment Actions
We should probably add a check here that requires either a limit or an end date, because otherwise you may generate infinite events. Let me add that safety test.
Comment Actions
- If an event generates ghosts, but has no limit and no end date, fatal so we don't generate inifnite events.