Have milestones inherit colors from parent projects
ClosedPublic
Actions

Authored by epriestley on Apr 6 2016, 8:58 PM.

Details

Reviewers

hach-que
chad

Maniphest Tasks

T10737: Milestone project tags should inherit their parent project's tag colour

Commits

rPded034474597: Have milestones inherit colors from parent projects

Summary

Fixes T10737. I agree that this is a better behavior than always making them blue (boring).

Test Plan

what

Screen Shot 2016-04-06 at 1.56.31 PM.png (235×265 px, 25 KB)

wut

Diff Detail

Repository

rP Phabricator

Branch

pcolor1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11562
Build 14443: Run Core Tests
Build 14442: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37696.Apr 6 2016, 8:58 PM

epriestley retitled this revision from to Have milestones inherit colors from parent projects.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, hach-que.

epriestley added a task: T10737: Milestone project tags should inherit their parent project's tag colour.

chad accepted this revision.Apr 6 2016, 9:06 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 6 2016, 9:06 PM

Closed by commit rPded034474597: Have milestones inherit colors from parent projects (authored by epriestley, committed by epriestley). · Explain WhyApr 6 2016, 9:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

storage/

PhabricatorProject.php

2 lines

Diff 37696

View Options

src/applications/project/storage/PhabricatorProject.php

Have milestones inherit colors from parent projectsClosedPublicActions