Page MenuHomePhabricator

Allow stacked comment actions to be explicitly ordered
ClosedPublic

Authored by epriestley on Apr 6 2016, 1:24 PM.
Tags
None
Referenced Files
F14361825: D15639.diff
Fri, Dec 20, 12:00 PM
F14355892: D15639.id37678.diff
Thu, Dec 19, 6:53 PM
Unknown Object (File)
Wed, Dec 18, 12:36 PM
Unknown Object (File)
Fri, Dec 6, 3:52 AM
Unknown Object (File)
Thu, Dec 5, 10:12 AM
Unknown Object (File)
Mon, Nov 25, 10:41 PM
Unknown Object (File)
Nov 2 2024, 7:53 AM
Unknown Object (File)
Oct 25 2024, 11:59 AM
Subscribers
None

Details

Summary

Ref T6027. Normally, actions use the same order as the form, but in some cases (like moving stuff on workboards) it makes sense to reorder them explicitly.

Pin "Move on board" near the bottom, and "projects/subscribers" at the bottom. I think these are generally reasonable rules in all cases.

Test Plan

Opened menu, saw slightly better action order.

Diff Detail

Repository
rP Phabricator
Branch
column6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11544
Build 14418: Run Core Tests
Build 14417: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow stacked comment actions to be explicitly ordered.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2016, 4:07 PM
This revision was automatically updated to reflect the committed changes.