Page MenuHomePhabricator

Allow stacked comment actions to be explicitly ordered
ClosedPublic

Authored by epriestley on Apr 6 2016, 1:24 PM.
Tags
None
Referenced Files
F19509294: D15639.diff
Sat, Jan 10, 5:27 PM
F19178394: D15639.id37686.diff
Tue, Dec 16, 12:53 AM
F19176081: D15639.id37686.diff
Mon, Dec 15, 11:40 PM
F19146587: D15639.diff
Dec 10 2025, 3:30 PM
F19082214: D15639.id37678.diff
Dec 2 2025, 10:26 AM
F19073567: D15639.id37686.diff
Dec 1 2025, 2:31 AM
F19065949: D15639.id37678.diff
Nov 30 2025, 3:33 AM
F19064093: D15639.id37678.diff
Nov 29 2025, 8:11 PM
Subscribers
None

Details

Summary

Ref T6027. Normally, actions use the same order as the form, but in some cases (like moving stuff on workboards) it makes sense to reorder them explicitly.

Pin "Move on board" near the bottom, and "projects/subscribers" at the bottom. I think these are generally reasonable rules in all cases.

Test Plan

Opened menu, saw slightly better action order.

Diff Detail

Repository
rP Phabricator
Branch
column6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11544
Build 14418: Run Core Tests
Build 14417: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow stacked comment actions to be explicitly ordered.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2016, 4:07 PM
This revision was automatically updated to reflect the committed changes.