Page MenuHomePhabricator
Differential D15610

Upate notifications for newPage
ClosedPublic
Actions

Authored by chad on Apr 4 2016, 7:13 PM.
Tags
None
Referenced Files
F14069234: D15610.diff
Wed, Nov 20, 4:43 AM
F14059151: D15610.diff
Sun, Nov 17, 5:54 PM
F14049224: D15610.diff
Thu, Nov 14, 11:47 AM
F14033103: D15610.diff
Sat, Nov 9, 4:43 PM
F14031707: D15610.id37622.diff
Sat, Nov 9, 11:46 AM
F14031706: D15610.id37621.diff
Sat, Nov 9, 11:46 AM
F14031705: D15610.id.diff
Sat, Nov 9, 11:46 AM
F14021912: D15610.diff
Wed, Nov 6, 1:53 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP23979a05aa95: Upate notifications for newPage
Summary

Single callsite, swap to newPage

Test Plan

Visit page, see same status message. Also remove device ready flag.

Diff Detail

Repository
rP Phabricator
Branch
notifications-newpage (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11488
Build 14333: Run Core Tests
Build 14332: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37621.Apr 4 2016, 7:13 PM
chad retitled this revision from to Upate notifications for newPage.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptApr 4 2016, 7:13 PM
epriestley accepted this revision.Apr 4 2016, 7:21 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 4 2016, 7:21 PM
Closed by commit rP23979a05aa95: Upate notifications for newPage (authored by chad, committed by chad). · Explain WhyApr 4 2016, 7:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
notification/
controller/
15 lines

Diff 37621

View Options

src/applications/notification/controller/PhabricatorNotificationStatusController.php

Loading...
Phabricator · Built by Phacility