Page MenuHomePhabricator
Differential D15591

Fix Legalpad "Sign" box
ClosedPublic
Actions

Authored by chad on Apr 3 2016, 2:50 AM.
Tags
None
Referenced Files
F18953750: D15591.diff
Wed, Nov 12, 8:08 AM
F18947651: D15591.id37582.diff
Tue, Nov 11, 10:09 PM
F18924093: D15591.id.diff
Sun, Nov 9, 5:21 PM
F18842214: D15591.id37582.diff
Oct 28 2025, 2:06 PM
F18840403: D15591.id37583.diff
Oct 28 2025, 12:27 AM
F18840401: D15591.id37582.diff
Oct 28 2025, 12:27 AM
F18836636: D15591.id37581.diff
Oct 27 2025, 3:03 AM
F18836547: D15591.id37581.diff
Oct 27 2025, 2:09 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPfa6151778fe8: Fix Legalpad "Sign" box
Summary

Missed converting this page, scenario. The box was poorly formatted.

Test Plan

Create a new document that needs signed, verify box is correctly spaced and colored.

Diff Detail

Repository
rP Phabricator
Branch
legalpad-newpage (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11450
Build 14277: Run Core Tests
Build 14276: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37581.Apr 3 2016, 2:50 AM
chad retitled this revision from to Fix Legalpad "Sign" box.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptApr 3 2016, 2:50 AM
chad updated this revision to Diff 37582.Apr 3 2016, 2:53 AM
  • clean up spacing in box too
epriestley accepted this revision.Apr 3 2016, 2:55 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 3 2016, 2:55 AM
Closed by commit rPfa6151778fe8: Fix Legalpad "Sign" box (authored by chad, committed by chad). · Explain WhyApr 3 2016, 2:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
legalpad/
controller/
17 lines
webroot/
rsrc/
css/
phui/
4 lines

Diff 37582

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...
View Options

webroot/rsrc/css/phui/phui-document-pro.css

Loading...
Phabricator · Built by Phacility