Clean up BadgeView a little bit
ClosedPublic
Actions

Authored by chad on Mar 31 2016, 9:59 PM.

Tags

None

Referenced Files

	F15522500: D15553.id37502.diff
	Sun, Apr 20, 8:24 PM

	F15518105: D15553.id.diff
	Sat, Apr 19, 10:55 AM

	F15514904: D15553.diff
	Fri, Apr 18, 6:34 AM

	F15485327: D15553.diff
	Wed, Apr 9, 11:05 PM

	F15481664: D15553.id37502.diff
	Tue, Apr 8, 10:21 PM

	F15446716: D15553.id37502.diff
	Thu, Mar 27, 7:55 PM

	F15416088: D15553.id37502.diff
	Mar 20 2025, 9:13 AM

	F15337880: D15553.diff
	Mar 9 2025, 8:08 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP59ef3a31d357: Clean up BadgeView a little bit

Summary

Uses BLUE_PROPERTY on Recipients box, removes redundent properties since we render the badge itself already.

Test Plan

View a badge with and without a description.

Diff Detail

Repository

rP Phabricator

Branch

badges-ui (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11367
Build 14151: Run Core Tests
Build 14150: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37502.Mar 31 2016, 9:59 PM

chad retitled this revision from to Clean up BadgeView a little bit.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMar 31 2016, 9:59 PM

epriestley accepted this revision.Mar 31 2016, 10:04 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 31 2016, 10:04 PM

Closed by commit rP59ef3a31d357: Clean up BadgeView a little bit (authored by chad, committed by chad). · Explain WhyMar 31 2016, 10:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

controller/

PhabricatorBadgesViewController.php

20 lines

view/

PhabricatorBadgesRecipientsListView.php

6 lines

Diff 37502

View Options

src/applications/badges/controller/PhabricatorBadgesViewController.php