[WIP] Tossing this up for safety and to read through it. Need to test, update some of the other flows. This updates everything in Auth for new UI and modern conventions.
Details
Details
- Reviewers
epriestley - Commits
- rP6bbba1e3151d: Update Auth for new UI
Loooots of random testing, new providers, edit providers, logging out, forgot password... more coming.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- auth-two (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 11365 Build 14148: Run Core Tests Build 14147: arc lint + arc unit
Event Timeline
Comment Actions
I haven't gone through 100% of this but everything looks good so far. Only maybe-weird thing I caught was that the positioning of "Add Provider" button in header seems possibly a little inconsistent (vs crumbs or header of table)? But it seems fine.
Comment Actions
Button on header is expected. That is, I'm pulling up the header that was previously on the object box and giving it a larger treatment, I think that makes the box below a little awkward, but I expect I'll be able to resolve this once I look at ApplicationSearch pages again.
| src/applications/auth/controller/config/PhabricatorAuthEditController.php | ||
|---|---|---|
| 273–274 | Not your change, but this seems a little weird/inconsistent. | |
| src/applications/auth/controller/config/PhabricatorAuthEditController.php | ||
|---|---|---|
| 273–274 | will kill it, was tempted to as it was | |