Moves everything I could find in Phortune to new UI layouts.
Details
Details
- Reviewers
epriestley - Commits
- Restricted Diffusion Commit
rP881785aba4bc: Update Phortune for two column, spruce up UI
Tested every page I could get two, unclear how to test subscriptions.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phortune-two (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 11263 Build 13993: Run Core Tests Build 13992: arc lint + arc unit
Event Timeline
Comment Actions
Only caught minor stuff:
- "Details" box on subscriptions is a little whack, I can fix this if you can't test it locally:
- Cancel button URI on high security checkpoint for managing a subscription is wrong (probably pre-existing, I'll send you a diff).
- Merchant member would be nice in the sidebar. :3
- Merchant "Description" is not separate (inconsistent?).
| src/applications/phortune/controller/PhortuneSubscriptionViewController.php | ||
|---|---|---|
| 85 | Should be setHeaderText() to fix header maybe? | |