Page MenuHomePhabricator

Update Phortune for two column, spruce up UI
ClosedPublic

Authored by chad on Mar 23 2016, 5:33 PM.
Tags
None
Referenced Files
F15781417: D15513.id37401.diff
Fri, May 30, 7:25 AM
Unknown Object (File)
Tue, May 27, 2:46 PM
Unknown Object (File)
Tue, May 27, 9:47 AM
Unknown Object (File)
Mon, May 26, 12:43 PM
Unknown Object (File)
Apr 29 2025, 2:11 PM
Unknown Object (File)
Apr 23 2025, 8:41 PM
Unknown Object (File)
Apr 20 2025, 2:54 AM
Unknown Object (File)
Mar 31 2025, 1:23 PM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP881785aba4bc: Update Phortune for two column, spruce up UI
Summary

Moves everything I could find in Phortune to new UI layouts.

Test Plan

Tested every page I could get two, unclear how to test subscriptions.

Diff Detail

Repository
rP Phabricator
Branch
phortune-two (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11261
Build 13989: Run Core Tests
Build 13988: arc lint + arc unit

Event Timeline

chad retitled this revision from to Update Phortune for two column, spruce up UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Only caught minor stuff:

  • "Details" box on subscriptions is a little whack, I can fix this if you can't test it locally:

Screen Shot 2016-03-23 at 10.38.53 AM.png (279×1 px, 36 KB)

  • Cancel button URI on high security checkpoint for managing a subscription is wrong (probably pre-existing, I'll send you a diff).
  • Merchant member would be nice in the sidebar. :3
  • Merchant "Description" is not separate (inconsistent?).

Screen Shot 2016-03-23 at 10.41.58 AM.png (501×1 px, 53 KB)

src/applications/phortune/controller/PhortuneSubscriptionViewController.php
85

Should be setHeaderText() to fix header maybe?

This revision is now accepted and ready to land.Mar 23 2016, 5:45 PM
chad edited edge metadata.
  • updates per commentittoes
This revision was automatically updated to reflect the committed changes.