Page MenuHomePhabricator
Differential D15501

Fix unusual use of Remarkup in Maniphest
ClosedPublic
Actions

Authored by epriestley on Mar 21 2016, 6:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 13, 12:34 PM
Unknown Object (File)
Dec 14 2024, 5:46 PM
Unknown Object (File)
Dec 8 2024, 6:04 PM
Unknown Object (File)
Nov 26 2024, 8:48 PM
Unknown Object (File)
Nov 26 2024, 8:30 PM
Unknown Object (File)
Nov 22 2024, 5:35 PM
Unknown Object (File)
Nov 22 2024, 3:32 PM
Unknown Object (File)
Nov 21 2024, 1:04 PM
View All Files
Subscribers
• quazie_dbx

Details

Reviewers
chad
Maniphest Tasks
T10234: When using a PhabricatorRemarkupCustomInlineRule with caching disabled, custom rules may end up with incorrect engines
Commits
Restricted Diffusion Commit
rP66946c09968c: Fix unusual use of Remarkup in Maniphest
Summary

Fixes T10234. This usage is unusual, out of date, and has some bad interactions with engines and custom rules.

Test Plan
  • Added CustomInlineCodeRule from P1129 as an extension rule.
  • Put a custom <code> ... </code> block in a Maniphest task description.
  • Saw fatal as described in task; applied change; saw rule work properly.

Diff Detail

Repository
rP Phabricator
Branch
rengine
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11233
Build 13947: Run Core Tests
Build 13946: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37370.Mar 21 2016, 6:21 PM
epriestley retitled this revision from to Fix unusual use of Remarkup in Maniphest.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10234: When using a PhabricatorRemarkupCustomInlineRule with caching disabled, custom rules may end up with incorrect engines.
Herald edited edge metadata. · View Herald TranscriptMar 21 2016, 6:21 PM
chad accepted this revision.Mar 21 2016, 6:24 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 21 2016, 6:24 PM
Closed by commit rP66946c09968c: Fix unusual use of Remarkup in Maniphest (authored by epriestley, committed by epriestley). · Explain WhyMar 21 2016, 6:24 PM
This revision was automatically updated to reflect the committed changes.
• quazie_dbx added a subscriber: • quazie_dbx.Mar 21 2016, 6:25 PM

Thank you for making this fix even though the task was closed as invalid.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
22 lines
infrastructure/
markup/
view/
14 lines

Diff 37370

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/infrastructure/markup/view/PHUIRemarkupView.php

Loading...
Phabricator · Built by Phacility