Page MenuHomePhabricator

Make Diffusion do an alright job on Git LFS objects
ClosedPublic

Authored by epriestley on Mar 18 2016, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 6:39 PM
Unknown Object (File)
Mon, Dec 2, 4:42 PM
Unknown Object (File)
Mon, Dec 2, 4:42 PM
Unknown Object (File)
Mon, Dec 2, 4:40 PM
Unknown Object (File)
Wed, Nov 27, 12:42 AM
Unknown Object (File)
Tue, Nov 26, 10:40 PM
Unknown Object (File)
Thu, Nov 21, 9:05 PM
Unknown Object (File)
Thu, Nov 21, 9:32 AM
Subscribers
None

Details

Summary

Ref T7789. This isn't the most perfect UI imaginable, but it's similar to what GitHub does and seems reasonable.

Test Plan

Screen Shot 2016-03-18 at 8.12.27 AM.png (1×1 px, 148 KB)

Screen Shot 2016-03-18 at 8.12.29 AM.png (1×1 px, 546 KB)

Diff Detail

Repository
rP Phabricator
Branch
lfs14
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/controller/DiffusionBrowseController.php:1955XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 11206
Build 13909: Run Core Tests
Build 13908: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make Diffusion do an alright job on Git LFS objects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 18 2016, 4:08 PM
This revision was automatically updated to reflect the committed changes.