Page MenuHomePhabricator
Differential D15492

Support pushing data into Git LFS
ClosedPublic
Actions

Authored by epriestley on Mar 18 2016, 1:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 2, 5:36 AM
Unknown Object (File)
Tue, Jan 28, 1:10 AM
Unknown Object (File)
Fri, Jan 24, 12:01 PM
Unknown Object (File)
Tue, Jan 21, 3:37 PM
Unknown Object (File)
Tue, Jan 21, 11:47 AM
Unknown Object (File)
Tue, Jan 21, 10:59 AM
Unknown Object (File)
Sun, Jan 19, 12:12 PM
Unknown Object (File)
Sat, Jan 18, 1:59 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7789: Support Git Large File Storage
T10604: Allow application code to stream request data
Commits
Restricted Diffusion Commit
rPa24f001b08ef: Support pushing data into Git LFS
Summary

Ref T7789. Ref T10604. This implements the upload action, which streams file data into Files.

This makes Git LFS actually work, at least roughly.

Test Plan
  • Tracked files in an LFS repository.
  • Pushed LFS data (git lfs track '*.png'; git add something.png; git commit -m ...; git push).
  • Pulled LFS data (git checkout master^; rm -rf .git/lfs; git checkout master; open something.png).
  • Verified LFS refs show up in the gitlfsref table.

Diff Detail

Repository
rP Phabricator
Branch
lfs12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11204
Build 13905: Run Core Tests
Build 13904: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37344.Mar 18 2016, 1:27 PM
epriestley retitled this revision from to Support pushing data into Git LFS.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10604: Allow application code to stream request data, T7789: Support Git Large File Storage.
Herald edited edge metadata. · View Herald TranscriptMar 18 2016, 1:27 PM
epriestley mentioned this in T7789: Support Git Large File Storage.Mar 18 2016, 1:42 PM
chad accepted this revision.Mar 18 2016, 3:53 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 18 2016, 3:53 PM
Closed by commit rPa24f001b08ef: Support pushing data into Git LFS (authored by epriestley, committed by epriestley). · Explain WhyMar 18 2016, 4:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
controller/
103 lines
files/
uploadsource/
4 lines
25 lines

Diff 37344

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionServeController.php

Loading...
View Options

src/applications/files/uploadsource/PhabricatorFileUploadSource.php

Loading...
View Options

src/applications/files/uploadsource/PhabricatorIteratorFileUploadSource.php

Loading...
Phabricator · Built by Phacility