Page MenuHomePhabricator
Differential D15476

Use new modular temporary auth token constants in one-time login and password reset flows
ClosedPublic
Actions

Authored by epriestley on Mar 16 2016, 12:37 PM.
Tags
None
Referenced Files
F15469666: D15476.diff
Fri, Apr 4, 3:19 PM
F15457166: D15476.id37302.diff
Sun, Mar 30, 2:42 PM
F15448699: D15476.id37310.diff
Fri, Mar 28, 6:26 AM
F15447540: D15476.id.diff
Fri, Mar 28, 12:31 AM
F15442045: D15476.diff
Wed, Mar 26, 9:06 PM
F15426176: D15476.id.diff
Sun, Mar 23, 7:33 AM
F15415597: D15476.diff
Thu, Mar 20, 6:52 AM
F15394993: D15476.diff
Sun, Mar 16, 2:34 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10603: Make AuthTemporaryTokens suitable for use as LFS tokens
Commits
Restricted Diffusion Commit
rP8e3ea4e034eb: Use new modular temporary auth token constants in one-time login and password…
Summary

Ref T10603. This converts existing hard-codes to modular constants.

Also removes one small piece of code duplication.

Test Plan
  • Performed one-time logins.
  • Performed a password reset.
  • Verified temporary tokens were revoked properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37302.Mar 16 2016, 12:37 PM
epriestley retitled this revision from to Use new modular temporary auth token constants in one-time login and password reset flows.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10603: Make AuthTemporaryTokens suitable for use as LFS tokens.
Herald edited edge metadata. · View Herald TranscriptMar 16 2016, 12:37 PM
chad accepted this revision.Mar 16 2016, 3:08 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 16 2016, 3:08 PM
Closed by commit rP8e3ea4e034eb: Use new modular temporary auth token constants in one-time login and password… (authored by epriestley, committed by epriestley). · Explain WhyMar 16 2016, 4:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
controller/
21 lines
engine/
17 lines
people/
editor/
6 lines
settings/
panel/
5 lines

Diff 37310

View Options

src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php

Loading...
View Options

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

Loading...
View Options

src/applications/people/editor/PhabricatorUserEditor.php

Loading...
View Options

src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php

Loading...
Phabricator · Built by Phacility