Page MenuHomePhabricator

Implement "git-lfs-authenticate" over SSH
ClosedPublic

Authored by epriestley on Mar 16 2016, 2:51 PM.
Tags
None
Referenced Files
F15516963: D15482.id.diff
Fri, Apr 18, 10:40 PM
F15516251: D15482.id37330.diff
Fri, Apr 18, 5:31 PM
F15513587: D15482.diff
Thu, Apr 17, 8:04 PM
F15501854: D15482.diff
Sun, Apr 13, 10:07 PM
F15461269: D15482.id37308.diff
Tue, Apr 1, 6:52 AM
F15446303: D15482.diff
Thu, Mar 27, 6:19 PM
F15430190: D15482.id37308.diff
Mon, Mar 24, 6:24 AM
F15422415: D15482.id37308.diff
Sat, Mar 22, 8:07 AM
Subscribers
None

Details

Summary

Ref T7789. This implements a (probably) usable "git-lfs-authenticate" on top of the new temporary token infrastructure.

This won't actually do anything yet, since nothing reads the tokens.

Test Plan
$ ./bin/ssh-exec --phabricator-ssh-user admin --ssh-command 'git-lfs-authenticate'
phabricator-ssh-exec: Expected `git-lfs-authenticate <path> <operation>`, but received too few arguments.
$ ./bin/ssh-exec --phabricator-ssh-user admin --ssh-command 'git-lfs-authenticate x'
phabricator-ssh-exec: Unrecognized repository path "x". Expected a path like "/diffusion/X/" or "/diffusion/123/".
$ ./bin/ssh-exec --phabricator-ssh-user admin --ssh-command 'git-lfs-authenticate diffusion/22'
Exception: Expected `git-lfs-authenticate <path> <operation>`, but received too few arguments.
$ ./bin/ssh-exec --phabricator-ssh-user admin --ssh-command 'git-lfs-authenticate diffusion/22 y'
Exception: Git LFS operation "y" is not supported by this server.
$ ./bin/ssh-exec --phabricator-ssh-user admin --ssh-command 'git-lfs-authenticate diffusion/22 upload'
{"header":{"Authorization":"Basic QGdpdC1sZnM6NmR2bDVreWVsaXNuMmtnNXBtbnZwM3VlaWhubmI1bmI="},"href":"http:\/\/local.phacility.com\/diffusion\/22\/new-callsign-free-repository.git\/info\/lfs"}

Diff Detail

Repository
rP Phabricator
Branch
lfs7
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/repository/storage/PhabricatorRepository.php:1835XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 11169
Build 13854: Run Core Tests
Build 13853: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Implement "git-lfs-authenticate" over SSH.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 16 2016, 6:16 PM
This revision was automatically updated to reflect the committed changes.