Page MenuHomePhabricator
Differential D15476

Use new modular temporary auth token constants in one-time login and password reset flows
ClosedPublic
Actions

Authored by epriestley on Mar 16 2016, 12:37 PM.
Tags
None
Referenced Files
F14348007: D15476.diff
Thu, Dec 19, 4:48 AM
F14315650: D15476.diff
Wed, Dec 18, 6:23 AM
Unknown Object (File)
Fri, Dec 13, 5:45 AM
Unknown Object (File)
Thu, Nov 28, 12:43 AM
Unknown Object (File)
Nov 19 2024, 5:03 AM
Unknown Object (File)
Oct 25 2024, 3:48 AM
Unknown Object (File)
Oct 24 2024, 12:00 PM
Unknown Object (File)
Oct 24 2024, 8:50 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10603: Make AuthTemporaryTokens suitable for use as LFS tokens
Commits
Restricted Diffusion Commit
rP8e3ea4e034eb: Use new modular temporary auth token constants in one-time login and password…
Summary

Ref T10603. This converts existing hard-codes to modular constants.

Also removes one small piece of code duplication.

Test Plan
  • Performed one-time logins.
  • Performed a password reset.
  • Verified temporary tokens were revoked properly.

Diff Detail

Repository
rP Phabricator
Branch
lfs2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11163
Build 13843: Run Core Tests
Build 13842: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37302.Mar 16 2016, 12:37 PM
epriestley retitled this revision from to Use new modular temporary auth token constants in one-time login and password reset flows.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10603: Make AuthTemporaryTokens suitable for use as LFS tokens.
Herald edited edge metadata. · View Herald TranscriptMar 16 2016, 12:37 PM
chad accepted this revision.Mar 16 2016, 3:08 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 16 2016, 3:08 PM
Closed by commit rP8e3ea4e034eb: Use new modular temporary auth token constants in one-time login and password… (authored by epriestley, committed by epriestley). · Explain WhyMar 16 2016, 4:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
controller/
21 lines
engine/
17 lines
people/
editor/
6 lines
settings/
panel/
5 lines

Diff 37302

View Options

src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php

Loading...
View Options

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

Loading...
View Options

src/applications/people/editor/PhabricatorUserEditor.php

Loading...
View Options

src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php

Loading...
Phabricator · Built by Phacility