Differential D15474

Fix an issue with rendering unit messages for diffs with no buildable
ClosedPublic
Actions

Authored by epriestley on Mar 15 2016, 3:17 PM.

Details

Reviewers

chad

Maniphest Tasks

T10591: viewing D8084 on this install results in InvalidArgumentException

Commits

Restricted Diffusion Commit
rP121e68e3adae: Fix an issue with rendering unit messages for diffs with no buildable

Summary

Fixes T10591. This was accidentally reverted in 148a50e48be146b88036032d1cad772d2627da28, probably when resolvign a merge/rebase.

Test Plan

Will push to production.

Diff Detail

Repository

rP Phabricator

Branch

dxbuildable

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11159
Build 13836: Run Core Tests
Build 13835: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37298.Mar 15 2016, 3:17 PM

epriestley retitled this revision from to Fix an issue with rendering unit messages for diffs with no buildable.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10591: viewing D8084 on this install results in InvalidArgumentException.

Herald edited edge metadata. · View Herald TranscriptMar 15 2016, 3:17 PM

chad accepted this revision.Mar 15 2016, 3:17 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 15 2016, 3:17 PM

thx!

Closed by commit rP121e68e3adae: Fix an issue with rendering unit messages for diffs with no buildable (authored by epriestley, committed by epriestley). · Explain WhyMar 15 2016, 3:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

4 lines

Diff 37298

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Fix an issue with rendering unit messages for diffs with no buildableClosedPublicActions