Page MenuHomePhabricator
Differential D15455

Add a footer to PHUITwoColumnView
ClosedPublic
Actions

Authored by chad on Mar 10 2016, 3:06 AM.
Tags
None
Referenced Files
F14107596: D15455.diff
Wed, Nov 27, 8:35 AM
Unknown Object (File)
Oct 27 2024, 10:53 PM
Unknown Object (File)
Oct 27 2024, 10:53 PM
Unknown Object (File)
Oct 26 2024, 9:24 PM
Unknown Object (File)
Oct 24 2024, 6:14 PM
Unknown Object (File)
Oct 19 2024, 8:02 PM
Unknown Object (File)
Oct 16 2024, 4:44 AM
Unknown Object (File)
Oct 15 2024, 10:46 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPe351eba74469: Add a footer to PHUITwoColumnView
Summary

This allows setting of full-width content underneath the two column, or full column all by itself. Maybe these names are bad.

Test Plan

Using these in Differential / Diffusion conversions.

Diff Detail

Repository
rP Phabricator
Branch
two-footer (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11109
Build 13759: Run Core Tests
Build 13758: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37246.Mar 10 2016, 3:06 AM
chad retitled this revision from to Add a footer to PHUITwoColumnView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 10 2016, 3:06 AM
epriestley accepted this revision.Mar 10 2016, 3:09 AM
epriestley edited edge metadata.

Is this any different than this?

return $this->newPage()
  ->setBlahBlah(...)
  ->appendChild(
    array(
      $two_column_view,
      $some_more_content,
    ));
This revision is now accepted and ready to land.Mar 10 2016, 3:09 AM
chad added a comment.Mar 10 2016, 3:09 AM

I suppose I can remove ActionList and PropertyList

epriestley added a comment.Mar 10 2016, 3:10 AM

Oh yeah, we probably got rid of all of those.

Go us!

chad added a comment.Mar 10 2016, 3:10 AM

Yes, it has built in page margins. I want to get away from setting margins for each component for different viewports and just use a page layout engine.

epriestley added a comment.Mar 10 2016, 3:10 AM

Ah, makes sense.

chad updated this revision to Diff 37247.Mar 10 2016, 3:16 AM
chad edited edge metadata.
  • remove lots of code
chad added a comment.Mar 10 2016, 3:17 AM

I suppose even this might move to subclassing newPage ? newObjectPage ?

Closed by commit rPe351eba74469: Add a footer to PHUITwoColumnView (authored by chad, committed by chad). · Explain WhyMar 10 2016, 3:18 AM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Mar 10 2016, 3:21 AM

I am trying to think what would make something like a redesign take less work in the future.

Revision Contents
Changeset List

PathSize
src/
view/
phui/
23 lines

Diff 37246

View Options

src/view/phui/PHUITwoColumnView.php

Loading...
Phabricator · Built by Phacility