Page MenuHomePhabricator
Differential D15449

Convert people manage page to two column
ClosedPublic
Actions

Authored by chad on Mar 9 2016, 4:52 PM.
Tags
None
Referenced Files
F15465448: D15449.id.diff
Wed, Apr 2, 6:52 PM
F15463263: D15449.diff
Tue, Apr 1, 9:52 PM
F15392230: D15449.id37232.diff
Sat, Mar 15, 1:58 PM
F15332583: D15449.diff
Mar 7 2025, 6:17 PM
Unknown Object (File)
Feb 9 2025, 12:59 AM
Unknown Object (File)
Jan 30 2025, 10:24 PM
Unknown Object (File)
Jan 30 2025, 4:45 PM
Unknown Object (File)
Jan 24 2025, 12:13 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10545: People and Projects are no longer flaggable
Commits
Restricted Diffusion Commit
rP1392872c5c03: Convert people manage page to two column
Summary

Ref T10545, this brings flags back? and converts the layout to two column w/curtain

Test Plan

View a few manage pages.

Diff Detail

Repository
rP Phabricator
Branch
people-two (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11093
Build 13738: Run Core Tests
Build 13737: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37231.Mar 9 2016, 4:52 PM
chad retitled this revision from to Convert people manage page to two column.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10545: People and Projects are no longer flaggable.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 9 2016, 4:52 PM
chad added inline comments.Mar 9 2016, 4:53 PM
src/applications/people/controller/PhabricatorPeopleProfileManageController.php
98–99

is this still actually needed? I've seen it left in other conversions.

epriestley accepted this revision.Mar 9 2016, 4:55 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/people/controller/PhabricatorPeopleProfileManageController.php
98–99

No. If I left it, it was accidental.

This revision is now accepted and ready to land.Mar 9 2016, 4:55 PM
Closed by commit rP1392872c5c03: Convert people manage page to two column (authored by chad, committed by chad). · Explain WhyMar 9 2016, 4:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37231

View Options

src/applications/people/controller/PhabricatorPeopleProfileManageController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
Phabricator · Built by Phacility